Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/FreeAlgebra): fix ported comments #7824

Closed
wants to merge 1 commit into from

Conversation

utensil
Copy link
Collaborator

@utensil utensil commented Oct 21, 2023

Per discussion on zulip.


The comments were ported from mathlib 3, but turned into semantically incorrect comments, this PR recovers the original semantics.

Open in Gitpod

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks! Can you look for other occurrences of \w--? I would guess that all line comments with no preceding whitespace are mathport errors.

@utensil
Copy link
Collaborator Author

utensil commented Oct 21, 2023

Can you look for other occurrences of \w--? I would guess that all line comments with no preceding whitespace are mathport errors.

Yes, I have run a search of inductive in Mathlib, gone through the 5 pages, and it seems to be the only case that matters:

It's safe to say that this is an edge case that has minimal impact.

EDIT: local search with variants of \w\ -- \w+\n found nothing suspicious too.

@bors
Copy link

bors bot commented Oct 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Algebra/FreeAlgebra): fix ported comments [Merged by Bors] - chore(Algebra/FreeAlgebra): fix ported comments Oct 21, 2023
@bors bors bot closed this Oct 21, 2023
@bors bors bot deleted the utensil/FreeAlgebra-comments branch October 21, 2023 13:37
@grunweg grunweg added the new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants