-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: real manifolds are locally path-connected #7877
Open
grunweg
wants to merge
26
commits into
master
Choose a base branch
from
MR-manifolds-locally-pathconnected
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+188
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proving image_congr' is a bit unwieldy as image_id as not be proven yet.
It's proposed that a code formatter remove those automatically, so we might as well remove them as we see them.
Have one sizable gap in mathlib: is missing definitions of and API around locally (path-)connected sets. The remaining scaffolding is done.
except for another missing lemma from mathlib.
grunweg
added
blocked-by-other-PR
This PR depends on another PR to Mathlib
awaiting-review
The author would like community review of the PR
t-differential-geometry
Manifolds etc
t-topology
Topological spaces, uniform spaces, metric spaces, filters
labels
Oct 23, 2023
grunweg
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Oct 31, 2023
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Nov 3, 2023
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
This PR depends on another PR to Mathlib
label
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-author
A reviewer has asked the author a question or requested changes
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
t-differential-geometry
Manifolds etc
t-topology
Topological spaces, uniform spaces, metric spaces, filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper way to prove this is showing that a charted space is locally path-connected iff its model space is.
(For connectedness, this is in mathlib.)
Note that #7822 and this PR used to have almost the same proof; I wonder if this can be refactored. (Both proofs basically argue that
I don't know if mathlib has such meta-reasoning currently.)