[Merged by Bors] - chore: remove Equiv.toFun_as_coe_apply
#7902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickMassot
added
awaiting-review
eric-wieser
reviewed
Oct 24, 2023
Comment on lines
-188
to
-193
| -- porting note: `simp` should prove this using `toFun_as_coe`, but it doesn't. | ||
| -- This might be a bug in `simp` -- see https://github.com/leanprover/lean4/issues/1937 | ||
| -- If this issue is fixed then the simp linter probably will start complaining, and | ||
| -- this theorem can be deleted hopefully without breaking any `simp` proofs. | ||
| @[simp] theorem toFun_as_coe_apply (e : α ≃ β) (x : α) : e.toFun x = e x := rfl | ||
|
|
There was a problem hiding this comment.
Why doesn't simpNF complain about this one?
eric-wieser
changed the title
Equiv.toFun_as_coe_apply
|
bors merge I tweaked the title to include the name of the lemma |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
This `simp` lemma was added during the port but tagged as probably unnecessary after fixing leanprover/lean4#1937. This PR confirms it is indeed no longer necessary. The only proofs that needed fixing were the one explicitly calling the new simp lemma. The porting note can go too.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Equiv.toFun_as_coe_applyEquiv.toFun_as_coe_apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
simplemma was added during the port but tagged as probably unnecessary after fixing leanprover/lean4#1937. This PR confirms it is indeed no longer necessary. The only proofs that needed fixing were the one explicitly calling the new simp lemma.The porting note can go too.