[Merged by Bors] - perf(FunLike.Basic): beta reduce CoeFun.coe
#7905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates `(fun a ↦ β) α` in the type when applying a `FunLike`. Not sure about the name.
negiizhao
added a commit
that referenced
this pull request
Oct 24, 2023
This eliminates `(fun a ↦ β) α` in the type when applying a `FunLike`. Not sure about the name. I'd like to see if it's much better than #7905.
|
!bench |
|
Here are the benchmark results for commit 4d6319b. Benchmark Metric Change
======================================================================================
+ build linting -6.2%
+ build tactic execution -5.1%
+ lint instructions -6.1%
+ ~Mathlib.Algebra.Category.ModuleCat.ChangeOfRings instructions -8.5%
+ ~Mathlib.Algebra.Category.Ring.Constructions instructions -38.4%
+ ~Mathlib.Algebra.DirectLimit instructions -19.6%
+ ~Mathlib.Algebra.Homology.ModuleCat instructions -32.2%
+ ~Mathlib.Algebra.Jordan.Basic instructions -5.9%
+ ~Mathlib.Algebra.Lie.Weights.Basic instructions -12.6%
+ ~Mathlib.AlgebraicGeometry.EllipticCurve.Point instructions -4.5%
+ ~Mathlib.AlgebraicGeometry.Morphisms.QuasiSeparated instructions -19.6%
+ ~Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties instructions -7.1%
+ ~Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Scheme instructions -7.1%
+ ~Mathlib.AlgebraicGeometry.Properties instructions -9.2%
+ ~Mathlib.AlgebraicGeometry.Spec instructions -11.5%
+ ~Mathlib.Analysis.NormedSpace.Multilinear instructions -1.8%
+ ~Mathlib.Analysis.NormedSpace.OperatorNorm instructions -2.0%
+ ~Mathlib.CategoryTheory.Abelian.InjectiveResolution instructions -1.6%
+ ~Mathlib.CategoryTheory.LiftingProperties.Adjunction instructions -22.3%
+ ~Mathlib.CategoryTheory.Monoidal.Internal.Module instructions -6.8%
+ ~Mathlib.Combinatorics.HalesJewett instructions -83.1%
+ ~Mathlib.FieldTheory.AbelRuffini instructions -6.1%
+ ~Mathlib.Geometry.Manifold.Algebra.LeftInvariantDerivation instructions -4.2%
- ~Mathlib.Geometry.Manifold.VectorBundle.SmoothSection instructions 153.3%
+ ~Mathlib.Geometry.RingedSpace.PresheafedSpace.Gluing instructions -3.5%
+ ~Mathlib.GroupTheory.HNNExtension instructions -7.0%
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.Contraction instructions -8.2%
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.Even instructions -13.6%
+ ~Mathlib.LinearAlgebra.DFinsupp instructions -12.2%
+ ~Mathlib.LinearAlgebra.Dual instructions -4.0%
+ ~Mathlib.LinearAlgebra.FreeModule.PID instructions -50.9%
+ ~Mathlib.LinearAlgebra.Multilinear.Basic instructions -9.9%
+ ~Mathlib.MeasureTheory.Integral.SetToL1 instructions -5.0%
+ ~Mathlib.NumberTheory.NumberField.Units instructions -3.6%
+ ~Mathlib.RepresentationTheory.Character instructions -28.9%
+ ~Mathlib.RepresentationTheory.GroupCohomology.Resolution instructions -56.1%
+ ~Mathlib.RingTheory.DedekindDomain.AdicValuation instructions -24.1%
+ ~Mathlib.RingTheory.IsTensorProduct instructions -9.3%
+ ~Mathlib.RingTheory.Kaehler instructions -2.9%
+ ~Mathlib.RingTheory.PowerSeries.Basic instructions -12.4%
+ ~Mathlib.RingTheory.RootsOfUnity.Basic instructions -6.1%
+ ~Mathlib.RingTheory.Trace instructions -6.5% |
|
!bench |
negiizhao
added
awaiting-review
|
Here are the benchmark results for commit 18d65c8. Benchmark Metric Change
======================================================================================
+ build linting -6.7%
+ build tactic execution -5.4%
+ lint instructions -6.1%
+ ~Mathlib.Algebra.Category.ModuleCat.ChangeOfRings instructions -8.5%
+ ~Mathlib.Algebra.Category.Ring.Constructions instructions -38.4%
+ ~Mathlib.Algebra.DirectLimit instructions -19.6%
+ ~Mathlib.Algebra.Homology.ModuleCat instructions -32.1%
+ ~Mathlib.Algebra.Jordan.Basic instructions -5.8%
+ ~Mathlib.Algebra.Lie.Weights.Basic instructions -12.6%
+ ~Mathlib.AlgebraicGeometry.EllipticCurve.Point instructions -4.5%
+ ~Mathlib.AlgebraicGeometry.Morphisms.QuasiSeparated instructions -19.6%
+ ~Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties instructions -7.1%
+ ~Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Scheme instructions -7.1%
+ ~Mathlib.AlgebraicGeometry.Properties instructions -9.2%
+ ~Mathlib.AlgebraicGeometry.Spec instructions -11.5%
+ ~Mathlib.Analysis.NormedSpace.OperatorNorm instructions -2.0%
+ ~Mathlib.CategoryTheory.Abelian.InjectiveResolution instructions -1.6%
+ ~Mathlib.CategoryTheory.LiftingProperties.Adjunction instructions -22.3%
+ ~Mathlib.CategoryTheory.Monoidal.Internal.Module instructions -6.8%
+ ~Mathlib.Combinatorics.HalesJewett instructions -83.1%
+ ~Mathlib.FieldTheory.AbelRuffini instructions -6.1%
+ ~Mathlib.Geometry.Manifold.Algebra.LeftInvariantDerivation instructions -4.2%
+ ~Mathlib.Geometry.RingedSpace.PresheafedSpace.Gluing instructions -3.4%
+ ~Mathlib.GroupTheory.HNNExtension instructions -7.0%
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.Contraction instructions -8.2%
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.Even instructions -13.6%
+ ~Mathlib.LinearAlgebra.DFinsupp instructions -12.3%
+ ~Mathlib.LinearAlgebra.Dual instructions -4.0%
+ ~Mathlib.LinearAlgebra.FreeModule.PID instructions -50.9%
+ ~Mathlib.LinearAlgebra.Multilinear.Basic instructions -9.9%
+ ~Mathlib.MeasureTheory.Integral.SetToL1 instructions -4.9%
+ ~Mathlib.NumberTheory.NumberField.Units instructions -3.6%
+ ~Mathlib.RepresentationTheory.Character instructions -28.9%
+ ~Mathlib.RepresentationTheory.GroupCohomology.Resolution instructions -56.0%
+ ~Mathlib.RingTheory.DedekindDomain.AdicValuation instructions -24.2%
+ ~Mathlib.RingTheory.IsTensorProduct instructions -9.3%
+ ~Mathlib.RingTheory.Kaehler instructions -2.9%
+ ~Mathlib.RingTheory.PowerSeries.Basic instructions -12.4%
+ ~Mathlib.RingTheory.RootsOfUnity.Basic instructions -6.1%
+ ~Mathlib.RingTheory.Trace instructions -6.5% |
eric-wieser
reviewed
Oct 26, 2023
eric-wieser
reviewed
Oct 26, 2023
eric-wieser
reviewed
Oct 26, 2023
eric-wieser
reviewed
Oct 26, 2023
Mathlib/Algebra/Lie/DirectSum.lean
Outdated
| @[simp] | ||
| -- @[simp] -- LHS doesn't simplify after #7905 |
There was a problem hiding this comment.
This one is rather worrying
eric-wieser
reviewed
Oct 26, 2023
eric-wieser
reviewed
Oct 26, 2023
| @@ -225,7 +225,7 @@ def stalkIso {X Y : PresheafedSpace.{_, _, v} C} (α : X ≅ Y) (x : X) : | |||
| set_option linter.uppercaseLean3 false in | |||
| #align algebraic_geometry.PresheafedSpace.stalk_map.stalk_iso AlgebraicGeometry.PresheafedSpace.stalkMap.stalkIso | |||
|
|
|||
| @[simp, reassoc, elementwise] | |||
There was a problem hiding this comment.
Why was this de-simped? Does the same comment apply as elsewhere about simpNF getting confused?
There was a problem hiding this comment.
Is a lemma with proof parameters that do not appear directly on the LHS (but in LHS there's a proof that uses it) appropriate as a simp lemma? If it should be, then I'll add a note.
There was a problem hiding this comment.
Yes, I think this is still fine as a simp lemma, since simp creates x ⤳ y as a side-goal. Did the linter complain?
There was a problem hiding this comment.
Yes, simpNF linter complains. I think this is because x ⤳ y doesn't appear directly on the LHS.
There was a problem hiding this comment.
Is x ⤳ y a proof as you said it was, or is it data?
There was a problem hiding this comment.
|
!bench |
eric-wieser
reviewed
Nov 15, 2023
eric-wieser
reviewed
Nov 15, 2023
Comment on lines
121
to
126
| theorem mk_reindex_cast' {n m : ℕ} (h : Fin n = Fin m) (x : (⨂[R]^n) M) : | ||
| GradedMonoid.mk (A := fun i => (⨂[R]^i) M) m | ||
| (PiTensorProduct.reindex R M (Equiv.cast h) x) = | ||
| GradedMonoid.mk n x := | ||
| Eq.symm (PiTensorProduct.gradedMonoid_eq_of_reindex_cast (fin_injective h) rfl) | ||
|
|
There was a problem hiding this comment.
I think we should get rid of this, since type equalities are evil. Does the proof below break without it?
(if not, then it doesn't belong in this PR anyway)
There was a problem hiding this comment.
For the same reason as above, the version with h : n = m is no longer a simp lemma. But removing it won't break things.
There was a problem hiding this comment.
I think all of the removed simp attributes should come with a comment referring to 7905; as far as I can tell, all of them look a bit iffy.
There was a problem hiding this comment.
This looks like a bug to me, leanprover-community/batteries#365.
I suggest you replace all of these with simpNF, and add a comment referencing std4#365.
There was a problem hiding this comment.
I've gone ahead and done that
eric-wieser
reviewed
Nov 15, 2023
eric-wieser
reviewed
Nov 15, 2023
| simp_rw [fundSystem, QuotientGroup.out_eq', ofMul_toMul] | ||
| simp_rw [fundSystem, QuotientGroup.out_eq']; rfl |
There was a problem hiding this comment.
This one is a bit weird; I'll take a look once a cache is ready.
eric-wieser
reviewed
Nov 15, 2023
| @@ -486,7 +486,6 @@ protected noncomputable def image {α β} (f : α → β) (s : Set α) (H : Inje | |||
| #align equiv.set.image Equiv.Set.image | |||
| #align equiv.set.image_apply Equiv.Set.image_apply | |||
|
|
|||
| @[simp] | |||
There was a problem hiding this comment.
Was this rejected by simpNF? If so, in favor of what lemma?
There was a problem hiding this comment.
⟨x, ⟨h, rfl⟩⟩ : f x ∈ f '' s is a proof.
There was a problem hiding this comment.
That's not supposed to matter... Either way, I'm happy with the comments for now, this PR is clearly a big improvement in general.
|
Here are the benchmark results for commit 6267d0a. Benchmark Metric Change
==================================================================================
+ build linting -8.9%
+ lint instructions -7.7%
+ lint wall-clock -7.7%
+ ~Mathlib.Algebra.Category.ModuleCat.ChangeOfRings instructions -7.8%
+ ~Mathlib.Algebra.Category.Ring.Constructions instructions -39.0%
+ ~Mathlib.Algebra.DirectLimit instructions -19.7%
+ ~Mathlib.Algebra.Homology.ModuleCat instructions -32.0%
+ ~Mathlib.Algebra.Jordan.Basic instructions -5.9%
+ ~Mathlib.Algebra.Lie.Weights.Basic instructions -10.0%
+ ~Mathlib.Algebra.Module.PID instructions -5.1%
+ ~Mathlib.AlgebraicGeometry.EllipticCurve.Point instructions -4.6%
+ ~Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Scheme instructions -7.3%
+ ~Mathlib.AlgebraicGeometry.Properties instructions -9.9%
+ ~Mathlib.AlgebraicGeometry.Spec instructions -11.7%
+ ~Mathlib.Analysis.NormedSpace.Multilinear instructions -3.9%
+ ~Mathlib.Analysis.NormedSpace.OperatorNorm instructions -2.1%
+ ~Mathlib.CategoryTheory.LiftingProperties.Adjunction instructions -23.0%
+ ~Mathlib.CategoryTheory.Monoidal.Internal.Module instructions -6.7%
+ ~Mathlib.Combinatorics.HalesJewett instructions -82.2%
+ ~Mathlib.Data.Sum.Lattice instructions -40.8%
+ ~Mathlib.FieldTheory.AbelRuffini instructions -6.2%
+ ~Mathlib.FieldTheory.Adjoin instructions -4.2%
+ ~Mathlib.Geometry.Manifold.Algebra.LeftInvariantDerivation instructions -4.3%
+ ~Mathlib.Geometry.RingedSpace.PresheafedSpace.Gluing instructions -2.2%
+ ~Mathlib.GroupTheory.HNNExtension instructions -7.5%
+ ~Mathlib.GroupTheory.PushoutI instructions -10.0%
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.Contraction instructions -8.0%
+ ~Mathlib.LinearAlgebra.CliffordAlgebra.Even instructions -13.7%
+ ~Mathlib.LinearAlgebra.DFinsupp instructions -13.9%
+ ~Mathlib.LinearAlgebra.Dual instructions -4.4%
- ~Mathlib.LinearAlgebra.FinsuppVectorSpace instructions 11.0%
+ ~Mathlib.LinearAlgebra.FreeModule.PID instructions -45.5%
+ ~Mathlib.LinearAlgebra.Multilinear.Basic instructions -8.7%
+ ~Mathlib.MeasureTheory.Integral.SetToL1 instructions -4.9%
+ ~Mathlib.NumberTheory.NumberField.Units instructions -4.1%
+ ~Mathlib.RepresentationTheory.Action instructions -1.6%
+ ~Mathlib.RepresentationTheory.Character instructions -28.0%
+ ~Mathlib.RepresentationTheory.GroupCohomology.Resolution instructions -66.7%
+ ~Mathlib.RepresentationTheory.Rep instructions -4.9%
+ ~Mathlib.RingTheory.AdjoinRoot instructions -3.5%
+ ~Mathlib.RingTheory.DedekindDomain.AdicValuation instructions -25.0%
+ ~Mathlib.RingTheory.IsTensorProduct instructions -10.0%
+ ~Mathlib.RingTheory.Kaehler instructions -4.4%
+ ~Mathlib.RingTheory.PowerSeries.Basic instructions -12.7%
+ ~Mathlib.RingTheory.RootsOfUnity.Basic instructions -7.4%
+ ~Mathlib.RingTheory.Trace instructions -6.6%
+ ~Mathlib.Topology.Sheaves.Stalks instructions -5.1% |
|
I'm happy with this now, thanks! I'd like to jump into an editor once the cache is ready and fiddle with a couple proofs; please ping me if this PR is green and I haven't already done so. If I don't respond, I'm fine with it being merged in 8 hours. |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
This eliminates `(fun a ↦ β) α` in the type when applying a `FunLike`. Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
CoeFun.coeCoeFun.coe
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
This eliminates `(fun a ↦ β) α` in the type when applying a `FunLike`. Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
This eliminates `(fun a ↦ β) α` in the type when applying a `FunLike`. Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
This eliminates `(fun a ↦ β) α` in the type when applying a `FunLike`. Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates
(fun a ↦ β) αin the type when applying aFunLike.Zulip