Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(CategoryTheory/Monoidal/Transport): flip the direction of μIso and εIso #7922

Closed
wants to merge 8 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Oct 25, 2023

Reversing these makes the API closer to that of CategoryTheory.LaxMonoidalFunctor, and doesn't seem to have much impact on proof difficulty.
This also golfs a proof rather than attempting to fix the old one.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR please-adopt awaiting-CI t-category-theory Category theory labels Oct 25, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Oct 25, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@joelriou
Copy link
Collaborator

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by joelriou.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 28, 2023
bors bot pushed a commit that referenced this pull request Oct 28, 2023
…Iso` and `εIso` (#7922)

Reversing these makes the API closer to that of `CategoryTheory.LaxMonoidalFunctor`, and doesn't seem to have much impact on proof difficulty.
This also golfs a proof rather than attempting to fix the old one.



Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
@bors
Copy link

bors bot commented Oct 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor(CategoryTheory/Monoidal/Transport): flip the direction of μIso and εIso [Merged by Bors] - refactor(CategoryTheory/Monoidal/Transport): flip the direction of μIso and εIso Oct 28, 2023
@bors bors bot closed this Oct 28, 2023
@bors bors bot deleted the eric-wieser/remove-symm branch October 28, 2023 15:58
grunweg pushed a commit that referenced this pull request Nov 1, 2023
…Iso` and `εIso` (#7922)

Reversing these makes the API closer to that of `CategoryTheory.LaxMonoidalFunctor`, and doesn't seem to have much impact on proof difficulty.
This also golfs a proof rather than attempting to fix the old one.



Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants