Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: move Submodule.{map,comap} to Algebra.Module.Submodule.Map #7925

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: move Submodule.{map,comap} to Algebra.Module.Submodule.Map #7925

wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Oct 25, 2023
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Oct 25, 2023
Closed
1 task
eric-wieser
eric-wieser approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the mem_map_equiv section belongs in this new file too?

@Ruben-VandeVelde
Copy link
Collaborator Author

Found a few more things, thanks for the suggestion

@eric-wieser
Copy link
Member

bors d=@Vierkantor

@bors
Copy link

bors bot commented Oct 25, 2023

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 25, 2023
Vierkantor
Vierkantor approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 26, 2023
bors bot pushed a commit that referenced this pull request Oct 26, 2023
@Ruben-VandeVelde
chore: move Submodule.{map,comap} to Algebra.Module.Submodule.Map (#7925
49f7f62 
)
@bors
Copy link

bors bot commented Oct 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: move Submodule.{map,comap} to Algebra.Module.Submodule.Map [Merged by Bors] - chore: move Submodule.{map,comap} to Algebra.Module.Submodule.Map Oct 26, 2023
@bors bors bot closed this Oct 26, 2023
@bors bors bot deleted the ruben-lm-split branch October 26, 2023 11:12
grunweg pushed a commit that referenced this pull request Nov 1, 2023
@Ruben-VandeVelde @grunweg
chore: move Submodule.{map,comap} to Algebra.Module.Submodule.Map (#7925
4bf5659 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ruben-VandeVelde @eric-wieser @Vierkantor @leanprover-community-mathlib4-bot