Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: pretty print as ↥S instead of { x // x ∈ S } for SetLike #7927

Closed
wants to merge 3 commits into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Oct 25, 2023

Adds a delaborator detecting { x // x ∈ S } where the membership uses SetLike.instMembership, since then this matches the CoeSort instance for SetLike.


Open in Gitpod

@kmill kmill added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Oct 25, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

LGTM, I wasn't able to trick it.

@bors
Copy link

bors bot commented Oct 25, 2023

✌️ kmill can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 25, 2023
@kmill
Copy link
Contributor Author

kmill commented Oct 25, 2023

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 25, 2023
bors bot pushed a commit that referenced this pull request Oct 25, 2023
…7927)

Adds a delaborator detecting `{ x // x ∈ S }` where the membership uses `SetLike.instMembership`, since then this matches the `CoeSort` instance for `SetLike`.
@bors
Copy link

bors bot commented Oct 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: pretty print as ↥S instead of { x // x ∈ S } for SetLike [Merged by Bors] - feat: pretty print as ↥S instead of { x // x ∈ S } for SetLike Oct 25, 2023
@bors bors bot closed this Oct 25, 2023
@bors bors bot deleted the kmill_delab_setlike branch October 25, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants