Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/DualNumber): ε commutes #7928

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

This doesn't generalize to TrivSqZeroExt, as we do not have a notion of Commute for smul.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Oct 25, 2023
@ocfnash
Copy link
Contributor

ocfnash commented Oct 26, 2023

I note that we already have:

example [CommSemiring R] : CommSemiring (DualNumber R) := inferInstance -- Uses `TrivSqZeroExt.commSemiring`

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 26, 2023
@eric-wieser
Copy link
Member Author

Indeed, though the result in this PR works for Semiring R as opposed to CommSemiring R!

@ocfnash
Copy link
Contributor

ocfnash commented Oct 26, 2023

Indeed, though the result in this PR works for Semiring R as opposed to CommSemiring R!

Of course, I realise this: hence I merged it.

What I was trying to say with my comment was "I was going to suggest we add this other commutativity fact [that everything commutes if the scalars commute] but I found it was already there, so I think these results are the only missing pieces and should just be merged".

@eric-wieser
Copy link
Member Author

so I think these results are the only missing pieces

I thought this too but then #7934 happened!

bors bot pushed a commit that referenced this pull request Oct 26, 2023
This doesn't generalize to `TrivSqZeroExt`, as we do not have a notion of `Commute` for `smul`.
@bors
Copy link

bors bot commented Oct 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Algebra/DualNumber): ε commutes [Merged by Bors] - chore(Algebra/DualNumber): ε commutes Oct 26, 2023
@bors bors bot closed this Oct 26, 2023
@bors bors bot deleted the eric-wieser/DualNumber-commute branch October 26, 2023 12:21
grunweg pushed a commit that referenced this pull request Nov 1, 2023
This doesn't generalize to `TrivSqZeroExt`, as we do not have a notion of `Commute` for `smul`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants