Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Nontrivial instances for ExteriorAlgebra, CliffordAlgebra #7985

Conversation

bustercopley
Copy link
Collaborator

@bustercopley bustercopley commented Oct 27, 2023

Using methods suggested by @eric-wieser
Zulip discussion

@bustercopley bustercopley force-pushed the richard-copley/ExteriorAlgebra-CliffordAlgebra-Nontrivial-instances branch from df653f4 to b6aa46c Compare October 27, 2023 13:32
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Please fix the style issues, but otherwise this looks great, thanks!

@bors
Copy link

bors bot commented Oct 27, 2023

✌️ bustercopley can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI labels Oct 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 27, 2023
@bustercopley bustercopley force-pushed the richard-copley/ExteriorAlgebra-CliffordAlgebra-Nontrivial-instances branch from b6aa46c to 9961954 Compare October 27, 2023 13:41
@bustercopley bustercopley force-pushed the richard-copley/ExteriorAlgebra-CliffordAlgebra-Nontrivial-instances branch from 9961954 to 57bff7a Compare October 27, 2023 13:53
@eric-wieser
Copy link
Member

Note that there is no need to force-push with mathlib; bors will squash your commits together anyway before merging.

@eric-wieser
Copy link
Member

bors merge

@bors
Copy link

bors bot commented Oct 27, 2023

Build failed (retrying...):

@bors
Copy link

bors bot commented Oct 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Nontrivial instances for ExteriorAlgebra, CliffordAlgebra [Merged by Bors] - feat: Nontrivial instances for ExteriorAlgebra, CliffordAlgebra Oct 27, 2023
@bors bors bot closed this Oct 27, 2023
@bors bors bot deleted the richard-copley/ExteriorAlgebra-CliffordAlgebra-Nontrivial-instances branch October 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants