Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Eventual boundedness of neighborhoods #8009

Closed
wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order theory labels Oct 29, 2023
Mathlib/Topology/Algebra/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Order/LiminfLimsup.lean Outdated Show resolved Hide resolved
Comment on lines +134 to +138
refine ⟨fun x ↦ ?_⟩
obtain ⟨a, ha⟩ := isBounded_ge_nhds x.1
obtain ⟨b, hb⟩ := isBounded_ge_nhds x.2
rw [← @Prod.mk.eta _ _ x, nhds_prod_eq]
exact ⟨(a, b), ha.prod_mk hb⟩
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of copying the proof, you can deduce it from the other one by order-dual arguments, with something like

Suggested change
refine ⟨fun x ↦ ?_⟩
obtain ⟨a, ha⟩ := isBounded_ge_nhds x.1
obtain ⟨b, hb⟩ := isBounded_ge_nhds x.2
rw [← @Prod.mk.eta _ _ x, nhds_prod_eq]
exact ⟨(a, b), ha.prod_mk hb⟩
⟨(instBoundedLENhdsClassProd (α := αᵒᵈ) (β := βᵒᵈ)).isBounded_le_nhds⟩

(if you have named the instance above). Same thing for the next instance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a forward-port PR, I think this is best left to a follow-up. The ideal place for this comment would have been leanprover-community/mathlib#18629!

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 30, 2023
YaelDillies and others added 2 commits October 30, 2023 18:29
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@eric-wieser
Copy link
Member

This looks like a faithful forward-port, so

bors merge

Please open a follow-up PR to address @sgouezel's concerns.

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 1, 2023
Copy link

bors bot commented Nov 1, 2023

Canceled.

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 1, 2023
@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Nov 1, 2023
Forward port leanprover-community/mathlib#18629




Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Eventual boundedness of neighborhoods [Merged by Bors] - feat: Eventual boundedness of neighborhoods Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@bors bors bot deleted the bounded_le_nhds_class branch November 1, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors. t-order Order theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants