Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Topology/Category): CompHaus, Profinite and Stonean are FinitaryExtensive. #8012

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(Topology/Category): CompHaus, Profinite and Stonean are FinitaryExtensive. #8012

wants to merge 9 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 29, 2023 •
edited by riccardobrasca
Loading

@erdOne erdOne changed the title feat(Topology/Category): CompHaus, Profinite and Stonean is FinitaryExtensive. feat(Topology/Category): CompHaus, Profinite and Stonean are FinitaryExtensive. Oct 29, 2023
@erdOne erdOne added awaiting-review The author would like community review of the PR t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters labels Oct 29, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Oct 29, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 30, 2023
@erdOne erdOne removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 30, 2023
dagurtomas
dagurtomas reviewed Oct 31, 2023
View reviewed changes
Mathlib/Topology/Category/TopCat/Limits/Pullbacks.lean
/-- The pullback along an embedding is (isomorphic to) the preimage. -/
noncomputable
def pullbackHomeoPreimage
{X Y Z : Type*} [TopologicalSpace X] [TopologicalSpace Y] [TopologicalSpace Z]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason not to use X Y Z : TopCat and f : X ⟶ Z etc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more universe polymorphic this way. I don't actually need this generality though.

Mathlib/Topology/Category/Stonean/Limits.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Category/Stonean/Limits.lean Outdated Show resolved Hide resolved
@erdOne @dagurtomas
Apply suggestions from code review
5e51bd1 
Co-authored-by: Dagur Tómas Ásgeirsson <dagurtomas@gmail.com>
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 1, 2023
bors bot pushed a commit that referenced this pull request Nov 1, 2023
@erdOne
feat(Topology/Category): CompHaus, Profinite and Stonean are `F…
95dc804 
…initaryExtensive`. (#8012)

Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@bors bors
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Topology/Category): CompHaus, Profinite and Stonean are FinitaryExtensive. [Merged by Bors] - feat(Topology/Category): CompHaus, Profinite and Stonean are FinitaryExtensive. Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@bors bors bot deleted the erd1/extensive-stonean branch November 1, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagurtomas dagurtomas dagurtomas approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erdOne @leanprover-community-mathlib4-bot @riccardobrasca @dagurtomas