[Merged by Bors] - fix: catch 'none' exception in Real.sqrt positivity extension #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwrensha
added
awaiting-review
|
Thanks! 🎉 |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 29, 2023
This example currently fails ```lean example (x : ℝ) : 0 ≤ Real.sqrt x := by positivity ``` due to the exception being thrown here: https://github.com/leanprover-community/mathlib4/blob/b56efa53d7479fda9740f364170cbaef34699dee/Mathlib/Tactic/Positivity/Core.lean#L304 It should succeed, because the junk value used for `sqrt` of a negative number is non-negative. This PR fixes it by catching the exception, a pattern used elsewhere: https://github.com/leanprover-community/mathlib4/blob/b56efa53d7479fda9740f364170cbaef34699dee/Mathlib/Tactic/Positivity/Core.lean#L325
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
grunweg
pushed a commit
that referenced
this pull request
Nov 1, 2023
This example currently fails ```lean example (x : ℝ) : 0 ≤ Real.sqrt x := by positivity ``` due to the exception being thrown here: https://github.com/leanprover-community/mathlib4/blob/b56efa53d7479fda9740f364170cbaef34699dee/Mathlib/Tactic/Positivity/Core.lean#L304 It should succeed, because the junk value used for `sqrt` of a negative number is non-negative. This PR fixes it by catching the exception, a pattern used elsewhere: https://github.com/leanprover-community/mathlib4/blob/b56efa53d7479fda9740f364170cbaef34699dee/Mathlib/Tactic/Positivity/Core.lean#L325
fgdorais
pushed a commit
that referenced
this pull request
Nov 1, 2023
This example currently fails ```lean example (x : ℝ) : 0 ≤ Real.sqrt x := by positivity ``` due to the exception being thrown here: https://github.com/leanprover-community/mathlib4/blob/b56efa53d7479fda9740f364170cbaef34699dee/Mathlib/Tactic/Positivity/Core.lean#L304 It should succeed, because the junk value used for `sqrt` of a negative number is non-negative. This PR fixes it by catching the exception, a pattern used elsewhere: https://github.com/leanprover-community/mathlib4/blob/b56efa53d7479fda9740f364170cbaef34699dee/Mathlib/Tactic/Positivity/Core.lean#L325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example currently fails
due to the exception being thrown here:
mathlib4/Mathlib/Tactic/Positivity/Core.lean
Line 304 in b56efa5
It should succeed, because the junk value used for
sqrtof a negative number is non-negative.This PR fixes it by catching the exception, a pattern used elsewhere:
mathlib4/Mathlib/Tactic/Positivity/Core.lean
Line 325 in b56efa5