Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: make Quotient.mk notation pretty print #8022

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: make Quotient.mk notation pretty print #8022

wants to merge 1 commit into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Oct 29, 2023

Open in Gitpod

@kmill kmill added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands awaiting-CI labels Oct 29, 2023
@kmill
Copy link
Contributor Author

kmill commented Oct 29, 2023

We could also implement a pretty printer using an app_unexpander, vs pulling in notation3. If anyone feels strongly about this, then feel free to write one 😄

@alexjbest
Copy link
Member

Seems fine to me, how many imports does it add though?

jcommelin
jcommelin approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 3, 2023
bors bot pushed a commit that referenced this pull request Nov 3, 2023
@kmill
feat: make Quotient.mk notation pretty print (#8022)
3d1e815
@bors bors
Copy link

bors bot commented Nov 3, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 3, 2023
@kmill
feat: make Quotient.mk notation pretty print (#8022)
a717942
@bors bors
Copy link

bors bot commented Nov 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: make Quotient.mk notation pretty print [Merged by Bors] - feat: make Quotient.mk notation pretty print Nov 3, 2023
@bors bors bot closed this Nov 3, 2023
@bors bors bot deleted the kmill_quotient_notation3 branch November 3, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kmill @alexjbest @jcommelin @leanprover-community-mathlib4-bot