New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Set/Image): re-use some variables #8054
Conversation
@@ -889,7 +889,7 @@ theorem _root_.Prod.range_snd [Nonempty α] : range (Prod.snd : α × β → β) | |||
#align prod.range_snd Prod.range_snd | |||
|
|||
@[simp] | |||
theorem range_eval {ι : Type*} {α : ι → Sort _} [∀ i, Nonempty (α i)] (i : ι) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's actually a universe generalization :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it, though? The variable I'm re-using is also a Type*. (Or is my mental model for this all too simple?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
This also generalizes a universe from `Type` to `Sort` in `Set.range_eval`
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Thanks for the quick review! |
This also generalizes a universe from `Type` to `Sort` in `Set.range_eval`
This also generalizes a universe from
Type
toSort
inSet.range_eval
Cherry-picked from #7822. I don't care about this strongly; happy to close this instead.