[Merged by Bors] - perf (Functor.Flat): restructure proof to reduce simp time #8065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
bench! |
|
!bench |
|
Here are the benchmark results for commit 1613e95. Benchmark Metric Change
=================================================================
- ~Mathlib.Analysis.NormedSpace.Multilinear instructions 1.6%
+ ~Mathlib.CategoryTheory.Functor.Flat instructions -56.7% |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
This file recently jumped almost 200% in #8051. Changing a `simpa using X` call into a `convert X <;> simp` cuts the clock time for the file in half.
|
bors merge- |
|
Canceled. |
|
Sorry there is a line I commented out that I should either delete or uncomment |
|
@j-loreaux if you want to pull the trigger again, please do. 🙏 |
mattrobball
added
awaiting-review
|
bors merge |
github-actions
bot
removed
the
awaiting-review
bors bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
This file recently jumped almost 200% in #8051. Changing a `simpa using X` call into a `convert X <;> simp` cuts the clock time for the file in half.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
fgdorais
pushed a commit
that referenced
this pull request
Nov 1, 2023
This file recently jumped almost 200% in #8051. Changing a `simpa using X` call into a `convert X <;> simp` cuts the clock time for the file in half.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file recently jumped almost 200% in #8051. Changing a
simpa using Xcall into aconvert X <;> simpcuts the clock time for the file in half.