[Merged by Bors] - refactor(Data/Matrix/Basic): split row/column decls #8089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits out `row`/`col`/`updateRow`/`updateColumn` to their own file.
eric-wieser
added
awaiting-review
eric-wieser
changed the title
|
LGTM! bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
This splits out `row`/`col`/`updateRow`/`updateColumn` to their own file, as `Data/Matrix/Basic` is getting rather large. The copyright comes from leanprover-community/mathlib#1816 and leanprover-community/mathlib#2480 There are no new lemmas in this PR, nor were any existing lemmas deleted. It's possible that even more lemmas could migrate to this new file (for instance, flipping the import with `Matrix.Notation` or `LinearAlgebra.Matrix.Trace`), but I've taken the conservative option of leaving those lemmas alone for now.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out
row/col/updateRow/updateColumnto their own file, asData/Matrix/Basicis getting rather large.The copyright comes from leanprover-community/mathlib#1816 and leanprover-community/mathlib#2480
There are no new lemmas in this PR, nor were any existing lemmas deleted.
It's possible that even more lemmas could migrate to this new file (for instance, flipping the import with
Matrix.NotationorLinearAlgebra.Matrix.Trace), but I've taken the conservative option of leaving those lemmas alone for now.