Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: rewrite lemma for Monoid.exponent (Multiplicative G) #8093

Closed
wants to merge 2 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Nov 1, 2023

This also fixes a to_additive naming error


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields etc) labels Nov 1, 2023
@@ -80,6 +80,12 @@ noncomputable def exponent :=

variable {G}

theorem _root_.AddMonoid.exponent_additive :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these would be good simp lemmas

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Alex that these should be simp, but otherwise

bors d+

It would be nice to have the same result for MulOpposite too, if we don't already have it; but you can declare that scope creep if you'd prefer.

Copy link

bors bot commented Nov 1, 2023

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Nov 1, 2023
@j-loreaux
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 4, 2023
bors bot pushed a commit that referenced this pull request Nov 4, 2023
This also fixes a `to_additive` naming error
Copy link

bors bot commented Nov 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: rewrite lemma for Monoid.exponent (Multiplicative G) [Merged by Bors] - feat: rewrite lemma for Monoid.exponent (Multiplicative G) Nov 4, 2023
@bors bors bot closed this Nov 4, 2023
@bors bors bot deleted the j-loreaux/exponent_multiplicative_additive branch November 4, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants