Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: comparison isomorphism for the two homology APIs #8114

Closed
wants to merge 1 commit into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Nov 2, 2023

This PR also changes the definition of group cohomology so as to use the new homology API.


When the ModuleCat variant of #7966 is done, this will ease computations in (low degree) group cohomology.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Nov 2, 2023
@joelriou joelriou added the awaiting-review The author would like community review of the PR label Nov 2, 2023
@jcommelin jcommelin changed the title feat: comparison isomorphism for the two homology API feat: comparison isomorphism for the two homology APIs Nov 2, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 2, 2023
bors bot pushed a commit that referenced this pull request Nov 2, 2023
This PR also changes the definition of group cohomology so as to use the new homology API.
Copy link

bors bot commented Nov 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: comparison isomorphism for the two homology APIs [Merged by Bors] - feat: comparison isomorphism for the two homology APIs Nov 2, 2023
@bors bors bot closed this Nov 2, 2023
@bors bors bot deleted the homology_comparison branch November 2, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants