Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.RelIso.Group #813

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: port Order.RelIso.Group #813

wants to merge 3 commits into from

Conversation

zeramorphic
Copy link
Collaborator

mathlib3 SHA: 62a5626868683c104774de8d85b9855234ac807c

I would appreciate advice on naming lemmas about coercions, the porting guide doesn't say what to do.

@zeramorphic
Copy from mathport
c4f69a3 
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
@zeramorphic
Convert coercions to toFun
5f1cc30 
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
@zeramorphic zeramorphic added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Dec 1, 2022
@zeramorphic
Add Order.RelIso.Group to Mathlib.lean
253ae8b 
Signed-off-by: thirdsgames <thirdsgames2018@gmail.com>
@ChrisHughes24
Copy link
Member

ChrisHughes24 commented Dec 1, 2022 •
edited

The convention I have already used was to use coe in the names of lemmas about coercions. Not much thought went into this however, but I would guess just leaving the names with coe is is the best for now?

@ChrisHughes24
Copy link
Member

The convention I have already used was to use coe in the names of lemmas about coercions. Not much thought went into this however, but I would guess just leaving the names with coe is is the best for now?

Some other PRs agreed with your convention however. I think we'll stick to your convention.

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 1, 2022
bors bot pushed a commit that referenced this pull request Dec 1, 2022
@zeramorphic
feat: port Order.RelIso.Group (#813)
fc1a3ee 
mathlib3 SHA: 62a5626868683c104774de8d85b9855234ac807c

I would appreciate advice on naming lemmas about coercions, the porting guide doesn't say what to do.
@bors
Copy link

bors bot commented Dec 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.RelIso.Group [Merged by Bors] - feat: port Order.RelIso.Group Dec 1, 2022
@bors bors bot closed this Dec 1, 2022
@bors bors bot deleted the Order.RelIso.Group branch December 1, 2022 16:08
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Dec 2, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17790)
02ca4ad 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.order.sub.canonical`: leanprover-community/mathlib4#814
* `category_theory.category.Rel`: leanprover-community/mathlib4#822
* `category_theory.category.basic`: leanprover-community/mathlib4#749
* `category_theory.functor.basic`: leanprover-community/mathlib4#749
* `category_theory.functor.category`: leanprover-community/mathlib4#749
* `category_theory.functor.functorial`: leanprover-community/mathlib4#822
* `category_theory.isomorphism`: leanprover-community/mathlib4#749
* `category_theory.natural_transformation`: leanprover-community/mathlib4#749
* `category_theory.thin`: leanprover-community/mathlib4#822
* `combinatorics.quiver.basic`: leanprover-community/mathlib4#749
* `combinatorics.quiver.path`: leanprover-community/mathlib4#811
* `data.psigma.order`: leanprover-community/mathlib4#815
* `data.stream.defs`: leanprover-community/mathlib4#665
* `order.boolean_algebra`: leanprover-community/mathlib4#794
* `order.heyting.basic`: leanprover-community/mathlib4#793
* `order.rel_iso.group`: leanprover-community/mathlib4#813
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Dec 3, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17790)
308f6d0 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.order.sub.canonical`: leanprover-community/mathlib4#814
* `category_theory.category.Rel`: leanprover-community/mathlib4#822
* `category_theory.category.basic`: leanprover-community/mathlib4#749
* `category_theory.functor.basic`: leanprover-community/mathlib4#749
* `category_theory.functor.category`: leanprover-community/mathlib4#749
* `category_theory.functor.functorial`: leanprover-community/mathlib4#822
* `category_theory.isomorphism`: leanprover-community/mathlib4#749
* `category_theory.natural_transformation`: leanprover-community/mathlib4#749
* `category_theory.thin`: leanprover-community/mathlib4#822
* `combinatorics.quiver.basic`: leanprover-community/mathlib4#749
* `combinatorics.quiver.path`: leanprover-community/mathlib4#811
* `data.psigma.order`: leanprover-community/mathlib4#815
* `data.stream.defs`: leanprover-community/mathlib4#665
* `order.boolean_algebra`: leanprover-community/mathlib4#794
* `order.heyting.basic`: leanprover-community/mathlib4#793
* `order.rel_iso.group`: leanprover-community/mathlib4#813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeramorphic @ChrisHughes24