Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Order/PartialSups): golf, add lemmas #8138

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 3, 2023

  • Add partialSups_iff_forall and partialSups_le_iff.
  • Use them to golf some proofs.
  • Drop partialSups_apply_mono
    because it's just (partialSups f).mono.
  • Add disjoint_partialSups_left and disjoint_partialSups_right.

Motivated by partialSups_le_iff
from the Mandelbrot Set Connectedness Project.

Co-authored-by: @girving


Open in Gitpod

- Add `partialSups_iff_forall` and `partialSups_le_iff`.
- Use them to golf some proofs.
- Drop `partialSups_apply_mono`
  because it's just `(partialSups f).mono`.
- Add `disjoint_partialSups_left` and `disjoint_partialSups_right`.
@urkud urkud added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Nov 3, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 3, 2023
bors bot pushed a commit that referenced this pull request Nov 3, 2023
- Add `partialSups_iff_forall` and `partialSups_le_iff`.
- Use them to golf some proofs.
- Drop `partialSups_apply_mono`
  because it's just `(partialSups f).mono`.
- Add `disjoint_partialSups_left` and `disjoint_partialSups_right`.

Motivated by `partialSups_le_iff`
from the Mandelbrot Set Connectedness Project.

Co-authored-by: @girving
Copy link

bors bot commented Nov 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Order/PartialSups): golf, add lemmas [Merged by Bors] - feat(Order/PartialSups): golf, add lemmas Nov 3, 2023
@bors bors bot closed this Nov 3, 2023
@bors bors bot deleted the YK-partial-sups branch November 3, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants