New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Order): restore missing simp attribute #8162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-mehta
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
labels
Nov 3, 2023
robertylewis
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
labels
Nov 7, 2023
b-mehta
added
awaiting-CI
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Nov 7, 2023
b-mehta
added
awaiting-review
The author would like community review of the PR
easy
< 20s of review time. See the lifecycle page for guidelines.
labels
Nov 8, 2023
bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 8, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
This lemma was marked `simp` in mathlib3, and the attribute seems to have gone missing during the port.
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
This lemma was marked `simp` in mathlib3, and the attribute seems to have gone missing during the port.
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
This lemma was marked `simp` in mathlib3, and the attribute seems to have gone missing during the port.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Order): restore missing simp attribute
[Merged by Bors] - chore(Order): restore missing simp attribute
Nov 8, 2023
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
This lemma was marked `simp` in mathlib3, and the attribute seems to have gone missing during the port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
easy
< 20s of review time. See the lifecycle page for guidelines.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lemma was marked
simp
in mathlib3, and the attribute seems to have gone missing during the port.