Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: Unify spelling of "prime factors" #8164

Closed
wants to merge 6 commits into from

Commits on Nov 3, 2023

  1. refactor: Unify spelling of "prime factors"

    mathlib can't make up its mind on whether to spell "the prime factors of `n`" as `n.factors.toFinset` or `n.factorization.support`, even though those two are defeq. This PR proposes to unify everything to a new definition `Nat.primeFactors`, and stream the existing scattered API about `n.factors.toFinset` and `n.factorization.support` to `Nat.primeFactors`. We also get to write a bit more API that didn't make sense before, eg `primeFactors_mono`.
    YaelDillies committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    43ec3ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f1eb49 View commit details
    Browse the repository at this point in the history
  3. move to PrimeFin

    YaelDillies committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f29464f View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. upstream more lemmas

    YaelDillies committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    6345b1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56e47e6 View commit details
    Browse the repository at this point in the history
  3. fix Data.Nat.Totient

    YaelDillies committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    379bade View commit details
    Browse the repository at this point in the history