Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: characterize summability by vanishing of tsums #8194

Closed
wants to merge 10 commits into from

Conversation

@alreadydone alreadydone added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Nov 5, 2023
Copy link
Collaborator

@MichaelStollBayreuth MichaelStollBayreuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alreadydone alreadydone changed the title feat: summability criterion in terms of vanishing of tsums feat: characterization of summability in terms of vanishing of tsums Nov 6, 2023
@alreadydone alreadydone changed the title feat: characterization of summability in terms of vanishing of tsums feat: characterization of summability by vanishing of tsums Nov 6, 2023
@alreadydone alreadydone changed the title feat: characterization of summability by vanishing of tsums feat: characterize summability by vanishing of tsums Nov 6, 2023
@@ -1189,6 +1189,36 @@ theorem Summable.subtype (hf : Summable f) (s : Set β) : Summable (f ∘ (↑)
hf.comp_injective Subtype.coe_injective
#align summable.subtype Summable.subtype

theorem summable_iff_vanishing_tsum : Summable f ↔
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direct implication in your theorem does require completeness, right? And in general the right hand side is equivalent to the fact that the sum over finsets is a Cauchy sequence, if I understand correctly. Could you give a statement like this, modelled on cauchySeq_finset_iff_vanishing, and then deduce your result in the complete case? Same thing for next theorem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean it doesn't require completeness, right? I can indeed remove the completeness assumption in the forward implications, even UniformAddGroup; only TopologicalAddGroup is required, and I've generalized tendsto_tsum_compl_atTop_zero to remove uniformity and golfed it using my theorem. However, I don't think I can state my theorems using cauchySeq, or even fit the two theorems into the filter framework, since I'm dealing with tsums over general Sets (not necessarily Finsets or complement of Finsets); we certainly can't use atTop on Set α and have to introduce some other filter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't clear, sorry. I am asking if the following is true:

theorem foobar {f : α → G} : (CauchySeq fun s : Finset β => ∑ b in s, f b) ↔
    ∀ e ∈ 𝓝 (0 : G), ∃ s : Finset α, ∀ t : Set α, Disjoint t s → (∑' a : t, f a) ∈ e

Copy link
Contributor Author

@alreadydone alreadydone Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the misunderstanding! Your approach indeed looks much nicer. I removed the summable_iff_... versions since they follow easily from the cauchySeq_finset_iff_... versions and summable_iff_cauchySeq_finset when the uniform group is complete, and since the reverse implication isn't very useful; summable_iff_vanishing will always be easier to verify.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 8, 2023
@alreadydone alreadydone added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 8, 2023
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 9, 2023
@alreadydone alreadydone added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 9, 2023
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also give a version of summable_iff_vanishing with your phrasing (probably summable_iff_tsum_vanishing)?
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 10, 2023

✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@alreadydone
Copy link
Contributor Author

Thanks! Could you also give a version of summable_iff_vanishing with your phrasing (probably summable_iff_tsum_vanishing)? bors d+

I removed them in this commit (see this comment for the rationale), but it should be easy to add back the CompleteUniformAddGroup section.

@sgouezel
Copy link
Contributor

Yes, I've seen that, but I think it's good to have it for coherence.

@sgouezel
Copy link
Contributor

Or remove also summable_iff_vanishing. But having one and not the other is strange.

Comment on lines 1145 to 1151
theorem cauchySeq_finset_iff_nat_tsum_vanishing {f : ℕ → α} :
(CauchySeq fun s : Finset ℕ ↦ ∑ n in s, f n) ↔
∀ e ∈ 𝓝 (0 : α), ∃ N : ℕ, ∀ t ⊆ {n | N ≤ n}, (∑' n : t, f n) ∈ e := by
refine cauchySeq_finset_iff_tsum_vanishing.trans ⟨fun van e he ↦ ?_, fun van e he ↦ ?_⟩ -- slow!
· obtain ⟨s, hs⟩ := van e he
refine cauchySeq_finset_iff_tsum_vanishing.trans ⟨fun vanish e he ↦ ?_, fun vanish e he ↦ ?_⟩
/- This is slow because CauchySeq requires SemilatticeSup (Finset ℕ) which requires
DecidableEq ℕ, which is the classical instance in `cauchySeq_finset_iff_tsum_vanishing`,
but a constructive one here. -/
Copy link
Contributor Author

@alreadydone alreadydone Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgouezel I diagnosed the slowness to be due to DecidableEq instance mismatch. Do you think I should add [DecidableEq β] to summable_iff_cauchySeq_finset etc.?

Update: commited; let's see if CI is happy. I can revert it if you don't like it for some reason.

It's a bit surprising that refine worked despite the instance mismatch; a Lean 4 feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit surprising that refine worked despite the instance mismatch; a Lean 4 feature?

Actually I think it's because CauchySeq actually only needs Preorder to work (for atTop to make sense), which is independent of the DecidableEq instance; it also explains why refine is slow, as Lean needs to unfold to the Preorder. We can probably get rid of some DecidableEq added here once we do the refactor there.

@alreadydone
Copy link
Contributor Author

Thanks!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 10, 2023
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 10, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: characterize summability by vanishing of tsums [Merged by Bors] - feat: characterize summability by vanishing of tsums Nov 10, 2023
@mathlib-bors mathlib-bors bot closed this Nov 10, 2023
@mathlib-bors mathlib-bors bot deleted the Summable_tsum_subtype branch November 10, 2023 21:41
grunweg pushed a commit that referenced this pull request Dec 15, 2023
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants