Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Complex/Basic): add missing cast lemmas for Rat #8225

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(Data/Complex/Basic): add missing cast lemmas for Rat #8225

wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

One Nat lemma was duplicated

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Nov 6, 2023
YaelDillies
YaelDillies approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's much cleaner!

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

jcommelin
jcommelin approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 10, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 10, 2023
@eric-wieser
chore(Data/Complex/Basic): add missing cast lemmas for Rat (#8225)
a244138 
One `Nat` lemma was duplicated
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 10, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Complex/Basic): add missing cast lemmas for Rat [Merged by Bors] - chore(Data/Complex/Basic): add missing cast lemmas for Rat Nov 10, 2023
@mathlib-bors mathlib-bors bot closed this Nov 10, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/complex-cast-lemmas branch November 10, 2023 09:13
grunweg pushed a commit that referenced this pull request Dec 15, 2023
@eric-wieser @grunweg
chore(Data/Complex/Basic): add missing cast lemmas for Rat (#8225)
521aa4f 
One `Nat` lemma was duplicated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eric-wieser @jcommelin @YaelDillies @leanprover-community-mathlib4-bot