Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(CategoryTheory): change the API for opposite (co)products to accept general (co)fans #8302

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - refactor(CategoryTheory): change the API for opposite (co)products to accept general (co)fans #8302

wants to merge 7 commits into from

Conversation

dagurtomas
Copy link
Collaborator

Open in Gitpod

@dagurtomas dagurtomas mentioned this pull request Nov 9, 2023
Closed
2 tasks
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI t-category-theory Category theory labels Nov 9, 2023
@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 10, 2023
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 10, 2023
b-mehta
b-mehta reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always in favour of using general limiting cones rather than using the chosen limit, thanks for working on this!

Mathlib/CategoryTheory/Limits/Opposites.lean Outdated Show resolved Hide resolved
dagurtomas and others added 2 commits November 10, 2023 22:46
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 12, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 12, 2023
@dagurtomas
refactor(CategoryTheory): change the API for opposite (co)products to…
63c34b1 
… accept general (co)fans (#8302)
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 12, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(CategoryTheory): change the API for opposite (co)products to accept general (co)fans [Merged by Bors] - refactor(CategoryTheory): change the API for opposite (co)products to accept general (co)fans Nov 12, 2023
@mathlib-bors mathlib-bors bot closed this Nov 12, 2023
@mathlib-bors mathlib-bors bot deleted the dagur_RefactorOpCoproduct branch November 12, 2023 14:29
alexkeizer pushed a commit that referenced this pull request Nov 17, 2023
@dagurtomas @alexkeizer
refactor(CategoryTheory): change the API for opposite (co)products to…
147b8b7 
… accept general (co)fans (#8302)
alexkeizer pushed a commit that referenced this pull request Nov 21, 2023
@dagurtomas @alexkeizer
refactor(CategoryTheory): change the API for opposite (co)products to…
2bed5c2 
… accept general (co)fans (#8302)
grunweg pushed a commit that referenced this pull request Dec 15, 2023
@dagurtomas @grunweg
refactor(CategoryTheory): change the API for opposite (co)products to…
4cb0dde 
… accept general (co)fans (#8302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta left review comments

@joelriou joelriou joelriou left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagurtomas @joelriou @b-mehta