[Merged by Bors] - feat(Data/Nat): add Nat.div_pow #8327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-mehta
added
the
awaiting-review
eric-wieser
reviewed
Nov 11, 2023
eric-wieser
approved these changes
Nov 11, 2023
|
✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
Adds the missing lemma Nat.div_pow, which seemed to be missing (at least, `exact?%` couldn't find it with all of Mathlib imported). Also moves `div_mul_div_comm` higher in the hierarchy (and golf) because it doesn't need the ordered semiring instance, cf the docstring of `Data/Nat/Order/Basic`. Co-authored-by: Bhavik Mehta <bm489@cam.ac.uk>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
Adds the missing lemma Nat.div_pow, which seemed to be missing (at least, `exact?%` couldn't find it with all of Mathlib imported). Also moves `div_mul_div_comm` higher in the hierarchy (and golf) because it doesn't need the ordered semiring instance, cf the docstring of `Data/Nat/Order/Basic`. Co-authored-by: Bhavik Mehta <bm489@cam.ac.uk>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
Adds the missing lemma Nat.div_pow, which seemed to be missing (at least, `exact?%` couldn't find it with all of Mathlib imported). Also moves `div_mul_div_comm` higher in the hierarchy (and golf) because it doesn't need the ordered semiring instance, cf the docstring of `Data/Nat/Order/Basic`. Co-authored-by: Bhavik Mehta <bm489@cam.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing lemma Nat.div_pow, which seemed to be missing (at least,
exact?%couldn't find it with all of Mathlib imported). Also movesdiv_mul_div_commhigher in the hierarchy (and golf) because it doesn't need the ordered semiring instance, cf the docstring ofData/Nat/Order/Basic.