[Merged by Bors] - chore: Fix name of Nat.card_mono
#8340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally put in the `PartENat` namespace in #8202. Also add `Set.Infinite.card_eq_zero` and fix capitalisation errors.
YaelDillies
added
the
awaiting-review
alreadydone
reviewed
Nov 12, 2023
Comment on lines
-183
to
+193
| theorem card_uLift (α : Type*) : card (ULift α) = card α := | ||
| card_congr Equiv.ulift | ||
| #align part_enat.card_ulift PartENat.card_uLift | ||
|
|
||
| @[simp] | ||
| theorem card_pLift (α : Type*) : card (PLift α) = card α := | ||
| card_congr Equiv.plift | ||
| #align part_enat.card_plift PartENat.card_pLift | ||
| @[simp] lemma card_ulift (α : Type*) : card (ULift α) = card α := card_congr Equiv.ulift | ||
| #align part_enat.card_ulift PartENat.card_ulift | ||
|
|
||
| lemma card_mono {s t : Set α} (ht : t.Finite) (h : s ⊆ t) : Nat.card s ≤ Nat.card t := | ||
| toNat_le_of_le_of_lt_aleph0 ht.lt_aleph0 <| mk_le_mk_of_subset h | ||
| @[simp] lemma card_plift (α : Type*) : card (PLift α) = card α := card_congr Equiv.plift | ||
| #align part_enat.card_plift PartENat.card_plift |
There was a problem hiding this comment.
Where did we decide PLift should turn into plift rather than pLift, and what's the rationale? (From the existing names in mathlib4 indeed plift seems to be the convention ...)
There was a problem hiding this comment.
First cluster of caps gets lowercased. That's the rule I know.
alreadydone
reviewed
Nov 12, 2023
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
alreadydone
approved these changes
Nov 12, 2023
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
This was accidentally put in the `PartENat` namespace in #8202. Also add `Set.Infinite.card_eq_zero` and fix capitalisation errors.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Nat.card_monoNat.card_mono
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
This was accidentally put in the `PartENat` namespace in #8202. Also add `Set.Infinite.card_eq_zero` and fix capitalisation errors.
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
This was accidentally put in the `PartENat` namespace in #8202. Also add `Set.Infinite.card_eq_zero` and fix capitalisation errors.
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
This was accidentally put in the `PartENat` namespace in #8202. Also add `Set.Infinite.card_eq_zero` and fix capitalisation errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally put in the
PartENatnamespace in #8202. Also addSet.Infinite.card_eq_zeroand fix capitalisation errors.