Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: split Analysis.Convex.Cone.Basic #8357

Closed
wants to merge 4 commits into from

Conversation

semorrison
Copy link
Contributor

Splits Mathlib.Analysis.Convex.Cone.Basic, to move Riesz extension and Hahn-Banach out of the basic file about definitions.


Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI labels Nov 11, 2023
Copy link
Collaborator

@apurvnakade apurvnakade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice idea! These two theorems seem too big for Basic.lean

The comments at the start of the files seem to be incorrectly arranged after the refactor. But otherwise looks good.

Mathlib/Analysis/Convex/Cone/Extension.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Convex/Cone/Dual.lean Outdated Show resolved Hide resolved
Co-authored-by: Apurva <apurvnakade@gmail.com>
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 13, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 14, 2023
@j-loreaux
Copy link
Collaborator

Thanks! Definitely a worthwhile split.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 16, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 16, 2023
Splits `Mathlib.Analysis.Convex.Cone.Basic`, to move Riesz extension and Hahn-Banach out of the basic file about definitions.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 16, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: split Analysis.Convex.Cone.Basic [Merged by Bors] - chore: split Analysis.Convex.Cone.Basic Nov 16, 2023
@mathlib-bors mathlib-bors bot closed this Nov 16, 2023
@mathlib-bors mathlib-bors bot deleted the split_convex_cone branch November 16, 2023 07:03
alexkeizer pushed a commit that referenced this pull request Nov 17, 2023
Splits `Mathlib.Analysis.Convex.Cone.Basic`, to move Riesz extension and Hahn-Banach out of the basic file about definitions.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
alexkeizer pushed a commit that referenced this pull request Nov 21, 2023
Splits `Mathlib.Analysis.Convex.Cone.Basic`, to move Riesz extension and Hahn-Banach out of the basic file about definitions.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
grunweg pushed a commit that referenced this pull request Dec 15, 2023
Splits `Mathlib.Analysis.Convex.Cone.Basic`, to move Riesz extension and Hahn-Banach out of the basic file about definitions.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants