[Merged by Bors] - fix(LinearAlgebra/{Free,Tensor,Clifford}Algebra): remove an unused SMulCommClass argument
#8373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SMulCommClass R S A` is always true when `Algebra R A` and `Algebra S A` and `A` is commutative, since the two actions factor via multiplication in `A`. I don't think mathlib actualy knows this fact yet, but in this particular case it's also true by definition.
eric-wieser
changed the title
SMulCommClass argument
eric-wieser
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 12, 2023
…MulCommClass` argument (#8373) `SMulCommClass R S A` is always true when `Algebra R A` and `Algebra S A` and `A` is commutative, since the two actions factor via multiplication in `A`. I don't think mathlib actually knows this fact yet, but in this particular case it's also true by definition.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
SMulCommClass argumentSMulCommClass argument
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
…MulCommClass` argument (#8373) `SMulCommClass R S A` is always true when `Algebra R A` and `Algebra S A` and `A` is commutative, since the two actions factor via multiplication in `A`. I don't think mathlib actually knows this fact yet, but in this particular case it's also true by definition.
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
…MulCommClass` argument (#8373) `SMulCommClass R S A` is always true when `Algebra R A` and `Algebra S A` and `A` is commutative, since the two actions factor via multiplication in `A`. I don't think mathlib actually knows this fact yet, but in this particular case it's also true by definition.
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
…MulCommClass` argument (#8373) `SMulCommClass R S A` is always true when `Algebra R A` and `Algebra S A` and `A` is commutative, since the two actions factor via multiplication in `A`. I don't think mathlib actually knows this fact yet, but in this particular case it's also true by definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMulCommClass R S Ais always true whenAlgebra R AandAlgebra S AandAis commutative, since the two actions factor via multiplication inA. I don't think mathlib actually knows this fact yet, but in this particular case it's also true by definition.