Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Algebra/DirectSum/Decomposition): some convenience API #8374

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(Algebra/DirectSum/Decomposition): some convenience API #8374

wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Nov 13, 2023
@eric-wieser eric-wieser mentioned this pull request Nov 13, 2023
Closed
ocfnash
ocfnash approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Two optional remarks but LGTM.

bors d+

Mathlib/Algebra/DirectSum/Decomposition.lean Show resolved Hide resolved
Mathlib/Algebra/DirectSum/Decomposition.lean Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 13, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 13, 2023
@eric-wieser
feat(Algebra/DirectSum/Decomposition): some convenience API (#8374)
47c407b
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

Build failed (retrying...):

  • Build

mathlib-bors bot pushed a commit that referenced this pull request Nov 13, 2023
@eric-wieser
feat(Algebra/DirectSum/Decomposition): some convenience API (#8374)
15ce6b6
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/DirectSum/Decomposition): some convenience API [Merged by Bors] - feat(Algebra/DirectSum/Decomposition): some convenience API Nov 13, 2023
@mathlib-bors mathlib-bors bot closed this Nov 13, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/more-Decomposition-API branch November 13, 2023 11:57
alexkeizer pushed a commit that referenced this pull request Nov 17, 2023
@eric-wieser @alexkeizer
feat(Algebra/DirectSum/Decomposition): some convenience API (#8374)
57e4032
alexkeizer pushed a commit that referenced this pull request Nov 21, 2023
@eric-wieser @alexkeizer
feat(Algebra/DirectSum/Decomposition): some convenience API (#8374)
5fae499
grunweg pushed a commit that referenced this pull request Dec 15, 2023
@eric-wieser @grunweg
feat(Algebra/DirectSum/Decomposition): some convenience API (#8374)
b46210a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @ocfnash @leanprover-community-mathlib4-bot