Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: golf tsum_setElem_eq_tsum_setElem_diff #8393

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: golf tsum_setElem_eq_tsum_setElem_diff #8393

wants to merge 2 commits into from

Conversation

alreadydone
Copy link
Contributor

Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-analysis Analysis (normed *, calculus) labels Nov 13, 2023
@alreadydone @github-actions
trailing whitespace
577ffe9 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
MichaelStollBayreuth
MichaelStollBayreuth approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@MichaelStollBayreuth MichaelStollBayreuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(You could use dot notation for Iff.symm, but this would probably make the code less readable.)

@ocfnash
Copy link
Contributor

ocfnash commented Nov 23, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 23, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2023
@alreadydone
chore: golf tsum_setElem_eq_tsum_setElem_diff (#8393)
d34a7de 
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 23, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: golf tsum_setElem_eq_tsum_setElem_diff [Merged by Bors] - chore: golf tsum_setElem_eq_tsum_setElem_diff Nov 23, 2023
@mathlib-bors mathlib-bors bot closed this Nov 23, 2023
@mathlib-bors mathlib-bors bot deleted the tsum_golf branch November 23, 2023 14:01
awueth pushed a commit that referenced this pull request Dec 19, 2023
@alreadydone @awueth
chore: golf tsum_setElem_eq_tsum_setElem_diff (#8393)
e4f6994 
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@MichaelStollBayreuth MichaelStollBayreuth MichaelStollBayreuth approved these changes

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alreadydone @ocfnash @MichaelStollBayreuth