[Merged by Bors] - fix: improvements I noticed when teaching #8420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
force-pushed
the
course_fixes
branch
from
ee424cb
to
19c1582
Compare
fpvandoorn
changed the title
sgouezel
reviewed
Dec 4, 2023
| @@ -105,7 +106,7 @@ instance : Inhabited (Closeds α) := | |||
| ⟨⊥⟩ | |||
|
|
|||
| @[simp, norm_cast] | |||
| theorem coe_sup (s t : Closeds α) : (↑(s ⊔ t) : Set α) = ↑s ∪ ↑t := | |||
| theorem coe_sup (s t : Closeds α) : (↑(s ⊔ t) : Set α) = ↑s ∪ ↑t := by | |||
There was a problem hiding this comment.
why did you change this one?
There was a problem hiding this comment.
I can revert this, but I needed to see the statement in the infoview to click on the types of things to ensure that the statement said the correct thing. It is annoying that this is only possible in tactic mode.
|
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Rename (and generalize and move) ``` Int.units_ne_neg_self -> units_ne_neg_self Int.neg_units_ne_self -> neg_units_ne_self ``` * Change the `simps` config for `Closeds` * Add some `gcongr`-lemmas (currently is a bit picky about the exact statement of lemmas tagged with `gcongr`, so I had to add some variants that I could tag).
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
* Rename (and generalize and move) ``` Int.units_ne_neg_self -> units_ne_neg_self Int.neg_units_ne_self -> neg_units_ne_self ``` * Change the `simps` config for `Closeds` * Add some `gcongr`-lemmas (currently is a bit picky about the exact statement of lemmas tagged with `gcongr`, so I had to add some variants that I could tag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simpsconfig forClosedsgcongr-lemmas (currently is a bit picky about the exact statement of lemmas tagged withgcongr, so I had to add some variants that I could tag).