[Merged by Bors] - fix: some cleanup in Nat.Factorial.Basic
#8422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
awaiting-review
| @@ -113,19 +113,11 @@ theorem extentClosure_iUnion (f : ι → Set β) : | |||
| intentClosure_iUnion _ _ | |||
| #align extent_closure_Union extentClosure_iUnion | |||
|
|
|||
| /- ./././Mathport/Syntax/Translate/Expr.lean:107:6: warning: expanding binder group (i j) -/ | |||
| /- ./././Mathport/Syntax/Translate/Expr.lean:107:6: warning: expanding binder group (i j) -/ | |||
There was a problem hiding this comment.
I think we still want to fix those once the syntax is supported, but perhaps we can find them without porting notes
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
|
Thanks! bors merge |
|
Already running a review |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Also remove some unimportant porting notes in `Order.Concept`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Nat.Factorial.BasicNat.Factorial.Basic
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Also remove some unimportant porting notes in `Order.Concept`.
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
* Also remove some unimportant porting notes in `Order.Concept`.
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Also remove some unimportant porting notes in `Order.Concept`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order.Concept.