[Merged by Bors] - chore: remove upstreamed lemmas #8432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
semorrison
commented
Nov 15, 2023
semorrison
commented
semorrison
added
awaiting-review
eric-wieser
reviewed
Nov 15, 2023
| @@ -3752,14 +3752,8 @@ end Diff | |||
|
|
|||
| /-! ### enum -/ | |||
|
|
|||
| theorem length_enumFrom : ∀ (n) (l : List α), length (enumFrom n l) = length l | |||
There was a problem hiding this comment.
What happened with the naming convention here? Has Std taken on a different scheme to mathlib?
There was a problem hiding this comment.
The "new" statement is (enumFrom n l).length = l.length. The naming has always been variable here.
There was a problem hiding this comment.
There are plenty of examples of both alternatives all over Mathlib and Std; I agree we should do something about it, but not in this PR. :-)
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.