[Merged by Bors] - chore(LinearAlgebra/AffineSpace/AffineSubspace): trivial affine morphisms #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
alreadydone
reviewed
Nov 17, 2023
|
|
||
| This is the affine version of `LinearEquiv.ofEq`. -/ | ||
| @[simps linear] | ||
| def ofEq (h : S₁ = S₂) : S₁ ≃ᵃ[k] S₂ where |
There was a problem hiding this comment.
Here the existing names are more chaotic, and ofEq is a reasonable choice:
Equiv.Set.ofEq, LinearEquiv.ofEq, RingEquiv.subringCongr, IntermediateField.equivOfEq, Subalgebra.equivOfEq
eric-wieser
changed the title
eric-wieser
changed the title
eric-wieser
force-pushed
the
eric-wieser/affine-topEquiv
branch
from
c3f2127
to
7af3498
Compare
alreadydone
approved these changes
Nov 20, 2023
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
…isms (#8434) We already have the `LinearEquiv` versions of these. This also copies the lemmas around the definition
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
…isms (#8434) We already have the `LinearEquiv` versions of these. This also copies the lemmas around the definition
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
…isms (#8434) We already have the `LinearEquiv` versions of these. This also copies the lemmas around the definition
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…isms (#8434) We already have the `LinearEquiv` versions of these. This also copies the lemmas around the definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the
LinearEquivversions of these.This also copies the lemmas around the definition