[Merged by Bors] - fix: have should check that the type is a type
#8445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmill
reviewed
Nov 16, 2023
|
bors d+ |
|
✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/bug.20in.20mathlib's.20have.20extension/near/402472594). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
have should check that the type is a typehave should check that the type is a type
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/bug.20in.20mathlib's.20have.20extension/near/402472594). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/bug.20in.20mathlib's.20have.20extension/near/402472594). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
As [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/bug.20in.20mathlib's.20have.20extension/near/402472594). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Zulip.