New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: bounds for Dirichlet characters #8449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelStollBayreuth
added
awaiting-review
The author would like community review of the PR
awaiting-CI
t-number-theory
Number theory (also use t-algebra or t-analysis to specialize)
t-algebra
Algebra (groups, rings, fields etc)
labels
Nov 16, 2023
laughinggas
reviewed
Nov 16, 2023
mo271
approved these changes
Nov 17, 2023
laughinggas
approved these changes
Nov 22, 2023
laughinggas
approved these changes
Nov 24, 2023
ocfnash
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
✌️ MichaelStollBayreuth can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 27, 2023
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
This adds `NumberTheory.DirichletCharacter.Bounds` containing proofs of `‖χ a‖ = 1` if `a` is a unit and `‖χ a‖ ≤ 1` in general, where `χ` is a Dirichlet character with values in a normed field. There are also two API lemmas added elsewhere that are used in the proofs.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat: bounds for Dirichlet characters
[Merged by Bors] - feat: bounds for Dirichlet characters
Nov 27, 2023
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
This adds `NumberTheory.DirichletCharacter.Bounds` containing proofs of `‖χ a‖ = 1` if `a` is a unit and `‖χ a‖ ≤ 1` in general, where `χ` is a Dirichlet character with values in a normed field. There are also two API lemmas added elsewhere that are used in the proofs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
t-algebra
Algebra (groups, rings, fields etc)
t-number-theory
Number theory (also use t-algebra or t-analysis to specialize)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
NumberTheory.DirichletCharacter.Bounds
containing proofs of‖χ a‖ = 1
ifa
is a unit and‖χ a‖ ≤ 1
in general, whereχ
is a Dirichlet character with values in a normed field.There are also two API lemmas added elsewhere that are used in the proofs.