Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: check exact? is fixed by leanprover/std4#368 #8458

Closed
wants to merge 4 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Nov 17, 2023

Adds a test for an exact? failure reported on zulip


Open in Gitpod

@semorrison semorrison added blocked-by-batt-PR This PR depends on a PR to Batteries awaiting-review awaiting-CI labels Nov 17, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib label Nov 17, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Nov 17, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@semorrison semorrison removed the blocked-by-batt-PR This PR depends on a PR to Batteries label Nov 17, 2023
@jcommelin
Copy link
Member

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 17, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 17, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 17, 2023
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 18, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 18, 2023
…8458)

Adds a test for an `exact?` failure reported on [zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/apply.3F.20failure/near/402534407)



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 18, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: check exact? is fixed by leanprover/std4#368 [Merged by Bors] - chore: check exact? is fixed by leanprover/std4#368 Nov 18, 2023
@mathlib-bors mathlib-bors bot closed this Nov 18, 2023
@mathlib-bors mathlib-bors bot deleted the exact_fix branch November 18, 2023 14:33
alexkeizer pushed a commit that referenced this pull request Nov 21, 2023
grunweg pushed a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants