[Merged by Bors] - chore: exact? runs nonspecific lemmas too #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
|
bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
leanprover-community-mathlib4-bot
added
merge-conflict
|
This PR/issue depends on:
|
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
semorrison
removed
merge-conflict
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
Previously, `exact?` has only indexed lemmas with a "specific" `DiscrTree` key (this meant: anything except `#[star]` or `#[Eq, star, star, star]`). This means that it wouldn't apply some very general lemmas, e.g. `le_antisymm`. The performance improvement here is pretty minor: the `DiscrTree` returns the more specific matches first, so we only attempt to apply the nonspecific keys last (i.e. if we would otherwise have already failed). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
Previously, `exact?` has only indexed lemmas with a "specific" `DiscrTree` key (this meant: anything except `#[star]` or `#[Eq, star, star, star]`). This means that it wouldn't apply some very general lemmas, e.g. `le_antisymm`. The performance improvement here is pretty minor: the `DiscrTree` returns the more specific matches first, so we only attempt to apply the nonspecific keys last (i.e. if we would otherwise have already failed). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
Previously, `exact?` has only indexed lemmas with a "specific" `DiscrTree` key (this meant: anything except `#[star]` or `#[Eq, star, star, star]`). This means that it wouldn't apply some very general lemmas, e.g. `le_antisymm`. The performance improvement here is pretty minor: the `DiscrTree` returns the more specific matches first, so we only attempt to apply the nonspecific keys last (i.e. if we would otherwise have already failed). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Previously, `exact?` has only indexed lemmas with a "specific" `DiscrTree` key (this meant: anything except `#[star]` or `#[Eq, star, star, star]`). This means that it wouldn't apply some very general lemmas, e.g. `le_antisymm`. The performance improvement here is pretty minor: the `DiscrTree` returns the more specific matches first, so we only attempt to apply the nonspecific keys last (i.e. if we would otherwise have already failed). Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
exact?has only indexed lemmas with a "specific"DiscrTreekey (this meant: anything except#[star]or#[Eq, star, star, star]).This means that it wouldn't apply some very general lemmas, e.g.
le_antisymm.The performance improvement here is pretty minor: the
DiscrTreereturns the more specific matches first, so we only attempt to apply the nonspecific keys last (i.e. if we would otherwise have already failed).