[Merged by Bors] - feat (Mathlib.RingTheory.Ideal.Operations) : Change hypotheses from ring to semiring #8469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdOne
reviewed
Nov 17, 2023
erdOne
reviewed
Nov 17, 2023
|
There was indeed a mistake in the CI: #8471. Merged master, which should fix it. |
XavierXarles
added
awaiting-review
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
erdOne
reviewed
Nov 28, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
fpvandoorn
reviewed
Nov 28, 2023
|
✌️ XavierXarles can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
|
Can you please address my other comments as well? |
Changed docs of map_of_equiv and comap_of_equiv as requested.
I hope I did all requested changes. The name map_comap_of_equiv (and all the others) are not mine, so I didn't changed, not to affect other parts of mathlib. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Yes, I had mixed feelings when asking you to fix something that was already wrong before, but thanks for fixing it! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…ing to semiring (#8469) Moved some results from ring to semiring. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com> Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…ing to semiring (#8469) Moved some results from ring to semiring. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com> Co-authored-by: Xavier Xarles <56635243+XavierXarles@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved some results from ring to semiring.
In Mathlib.RingTheory.Ideal.Operations I moved two results from ring to semiring with the same proof, and two I changed the proof.