Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: copy norm_cast attributes in to_additive #847

Closed
wants to merge 3 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Dec 4, 2022

No description provided.

@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Dec 6, 2022

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@[to_additive, norm_cast]
@[norm_cast, to_additive]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restored the order these were in in mathlib3. I'm not sure if mathport or the porter switched these.

Copy link
Contributor

@semorrison semorrison Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was the porter.

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 6, 2022
bors bot pushed a commit that referenced this pull request Dec 6, 2022
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Dec 6, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: copy norm_cast attributes in to_additive [Merged by Bors] - chore: copy norm_cast attributes in to_additive Dec 6, 2022
@bors bors bot closed this Dec 6, 2022
@bors bors bot deleted the mcdoll/to_additive_attr branch December 6, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants