[Merged by Bors] - feat: port Data.Stream.Init #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
siddhartha-gadgil
added
awaiting-review
siddhartha-gadgil
changed the title
|
Should the file |
|
No, unless it is moved in lean 3 as well. It is a lean 3 core file but it's not in |
semorrison
added
the
merge-conflict
Ruben-VandeVelde
approved these changes
Dec 21, 2022
kbuzzard
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
This is great. A bunch of auto-ported proofs didn't work for you because rw [def] seems to behave differently in Lean 4, in the middle of a proof involved in a definition of def. I looked at your workarounds and fed some additional information into the rewrites and got them working again; as a result I could golf a bunch of your proofs back to versions which far more closely approximate the autoported versions. Not a big deal but I thought you might be interested! Whether or not you add these golfs, this PR is ready to merge.
jcommelin
added
awaiting-author
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
…unity/mathlib4 into data_stream_init
siddhartha-gadgil
added
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
e574b1a4e891376b0ef974b926da39e05da12a06 Due to name collisions with `Stream` in Lean 4, the structure is `Stream'` as earlier defined. Recursive proofs were changed a bit to show termination. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e574b1a4e891376b0ef974b926da39e05da12a06
Due to name collisions with
Streamin Lean 4, the structure isStream'as earlier defined. Recursive proofs were changed a bit to show termination.