Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory): description of products and pullbacks in concrete categories #8507

Closed
wants to merge 16 commits into from

Conversation

joelriou
Copy link
Collaborator


Open in Gitpod

@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 20, 2023
@joelriou joelriou added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 21, 2023
@joelriou joelriou added awaiting-review WIP Work in progress and removed awaiting-review labels Nov 21, 2023
@joelriou joelriou removed the WIP Work in progress label Nov 21, 2023
@joelriou
Copy link
Collaborator Author

Following zulip discussion https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Limits.20in.20FintypeCat/near/403470370 I have added similar results for the terminal object and binary products.

Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion. Otherwise LGTM.

Mathlib/CategoryTheory/Limits/Shapes/ConcreteCategory.lean Outdated Show resolved Hide resolved
@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 24, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@erdOne
Copy link
Member

erdOne commented Nov 24, 2023

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 25, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 25, 2023
…te categories (#8507)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 25, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): description of products and pullbacks in concrete categories [Merged by Bors] - feat(CategoryTheory): description of products and pullbacks in concrete categories Nov 25, 2023
@mathlib-bors mathlib-bors bot closed this Nov 25, 2023
@mathlib-bors mathlib-bors bot deleted the concrete-pullback branch November 25, 2023 10:19
awueth pushed a commit that referenced this pull request Dec 19, 2023
…te categories (#8507)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants