[Merged by Bors] - feat: add Algebra.coe_trace_int #8513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From flt-regular. Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Ruben-VandeVelde
added
the
awaiting-review
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
alreadydone
reviewed
Nov 19, 2023
Comment on lines
33
to
36
| theorem Algebra.coe_norm_int : Algebra.norm ℤ x = Algebra.norm ℚ (x : K) := | ||
| (Algebra.norm_localization (R := ℤ) (Rₘ := ℚ) (S := 𝓞 K) (Sₘ := K) (nonZeroDivisors ℤ) x).symm | ||
|
|
||
| end rat | ||
| theorem Algebra.coe_trace_int : Algebra.trace ℤ _ x = Algebra.trace ℚ K x := |
There was a problem hiding this comment.
Maybe make one more argument implicit in Algebra.trace in a future PR?
eric-wieser
reviewed
Nov 19, 2023
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
|
Build failed: |
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From flt-regular.