[Merged by Bors] - fix: removed (incorrect) test for symm, trans attributes #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test was failing for dependent cases eg #855
siddhartha-gadgil
changed the title
siddhartha-gadgil
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
Fixes error I made: introducing a test for `symm` and `trans` attributes to check that the lemmas were "genuinely" symm/trans lemmas. However the tests had false positives, e.g. #855 (which has been added to the tests). This short commit removes the tests. They were not present in `mathlib3` anyway and the worst that happens if a lemma is incorrectly labelled is that the `symm` tactic tries and fails with this. As a warning it may be useful to have a test, but it should have no false positives. For now it seems the best approach is to drop the test.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
Fixes error I made: introducing a test for `symm` and `trans` attributes to check that the lemmas were "genuinely" symm/trans lemmas. However the tests had false positives, e.g. #855 (which has been added to the tests). This short commit removes the tests. They were not present in `mathlib3` anyway and the worst that happens if a lemma is incorrectly labelled is that the `symm` tactic tries and fails with this. As a warning it may be useful to have a test, but it should have no false positives. For now it seems the best approach is to drop the test.
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
semorrison
added a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error I made: introducing a test for
symmandtransattributes to check that the lemmas were "genuinely" symm/trans lemmas. However the tests had false positives, e.g. #855 (which has been added to the tests).This short commit removes the tests. They were not present in
mathlib3anyway and the worst that happens if a lemma is incorrectly labelled is that thesymmtactic tries and fails with this.As a warning it may be useful to have a test, but it should have no false positives. For now it seems the best approach is to drop the test.