Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: m/gcd m n and n coprime if m squarefree #8578

Closed
wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator


Open in Gitpod

@alexjbest
Copy link
Member

Looks like a good candidate for dot notation, also should be true if either m is Nonzero or n is Nonzero I think. So the hypothesis could be an or statement

@YaelDillies
Copy link
Collaborator Author

This can't reasonably be dot notation because the predicate is Squarefree, not Nat.Squarefree. The Squarefree m hypothesis already implies m ≠ 0 (and indeed the statement is false if we remove the n ≠ 0 assumption).

@alexjbest
Copy link
Member

Ah right, this is Nat.gcd, we really should combine those at some point (I'd imagine this lemma would be true more generally then).

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Nov 24, 2023
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 24, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 24, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 24, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: m/gcd m n and n coprime if m squarefree [Merged by Bors] - feat: m/gcd m n and n coprime if m squarefree Nov 24, 2023
@mathlib-bors mathlib-bors bot closed this Nov 24, 2023
@mathlib-bors mathlib-bors bot deleted the coprime_div_gcd_of_squarefree branch November 24, 2023 10:48
awueth pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants