New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor: use the new homology API for right derived functors #8593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelriou
changed the title
refactor(Algebra/Homology): refactors injective resolutions and right derived functors using the new homology API
refactor: refactors injective resolutions and right derived functors using the new homology API
Nov 23, 2023
joelriou
changed the title
refactor: refactors injective resolutions and right derived functors using the new homology API
refactor: use the new homology API for right derived functors
Nov 23, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
label
Nov 23, 2023
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
label
Nov 24, 2023
This PR/issue depends on: |
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Nov 24, 2023
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Nov 24, 2023
joelriou
added
the
awaiting-review
The author would like community review of the PR
label
Nov 24, 2023
jcommelin
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Nov 28, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Injective resolutions and right derived functors are redefined using the new homology API. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
refactor: use the new homology API for right derived functors
[Merged by Bors] - refactor: use the new homology API for right derived functors
Nov 28, 2023
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Injective resolutions and right derived functors are redefined using the new homology API. Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injective resolutions and right derived functors are redefined using the new homology API.
After this PR is merged, I will do a similar refactor for left derived functors, but that PR shall have slightly bigger proportions because right derived functors are currently not in use, but left derived are: Ext modules, group cohomology, local cohomology. After that, the homology refactor shall be essentially complete: there might still be some results for the old homology API that have no equivalent for the new API, but once this is fixed, it will be possible to remove the old API.