Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: use the new homology API for right derived functors #8593

Closed
wants to merge 14 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Nov 23, 2023

Injective resolutions and right derived functors are redefined using the new homology API.


After this PR is merged, I will do a similar refactor for left derived functors, but that PR shall have slightly bigger proportions because right derived functors are currently not in use, but left derived are: Ext modules, group cohomology, local cohomology. After that, the homology refactor shall be essentially complete: there might still be some results for the old homology API that have no equivalent for the new API, but once this is fixed, it will be possible to remove the old API.

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Nov 23, 2023
@joelriou joelriou changed the title refactor(Algebra/Homology): refactors injective resolutions and right derived functors using the new homology API refactor: refactors injective resolutions and right derived functors using the new homology API Nov 23, 2023
@joelriou joelriou changed the title refactor: refactors injective resolutions and right derived functors using the new homology API refactor: use the new homology API for right derived functors Nov 23, 2023
joelriou and others added 2 commits November 23, 2023 15:45
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Nov 23, 2023
@joelriou joelriou removed the WIP Work in progress label Nov 23, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Nov 24, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 24, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 24, 2023
@joelriou joelriou added the awaiting-review The author would like community review of the PR label Nov 24, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 28, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 28, 2023
Injective resolutions and right derived functors are redefined using the new homology API.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 28, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: use the new homology API for right derived functors [Merged by Bors] - refactor: use the new homology API for right derived functors Nov 28, 2023
@mathlib-bors mathlib-bors bot closed this Nov 28, 2023
@mathlib-bors mathlib-bors bot deleted the refactor-right-derived branch November 28, 2023 15:31
awueth pushed a commit that referenced this pull request Dec 19, 2023
Injective resolutions and right derived functors are redefined using the new homology API.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants