[Merged by Bors] - chore(NormedSpace/Complemented): review API #8596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
sgouezel
reviewed
Dec 3, 2023
|
|
||
| theorem closedComplemented_of_closed_compl (h : IsCompl p q) (hp : IsClosed (p : Set E)) | ||
| theorem ClosedComplemented.of_isClosed_isCompl (h : IsCompl p q) (hp : IsClosed (p : Set E)) |
There was a problem hiding this comment.
this name is strange, because it can't be used with dot notation. Maybe IsCompl.closedComplemented_of_isClosed?
There was a problem hiding this comment.
It can be used with the new Lean 4 dot notation, see line 141 below. I can add an alias, if you want.
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
- use `And` instead of `Exists`; - move lemmas from `Subspace` to `Submodule` namespace; - rename some lemmas to enable dot notation; - add `ClosedComplemented.exists_submodule_equiv_prod`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
- use `And` instead of `Exists`; - move lemmas from `Subspace` to `Submodule` namespace; - rename some lemmas to enable dot notation; - add `ClosedComplemented.exists_submodule_equiv_prod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andinstead ofExists;SubspacetoSubmodulenamespace;ClosedComplemented.exists_submodule_equiv_prod.