[Merged by Bors] - feat({ Tactic + test }/MoveAdd): make And/Or left-associative
#8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
changed the title
And/Or left-associativeAnd/Or left-associative
eric-wieser
reviewed
Nov 26, 2023
robertylewis
added
awaiting-author
adomani
added
awaiting-review
and removed
awaiting-author
eric-wieser
reviewed
Nov 27, 2023
| | [a] => a | ||
| | a::as => | ||
| if left_assoc? then | ||
| Expr.app (prepOp.app a) (sumList prepOp true as) |
There was a problem hiding this comment.
Or alternatively (untested):
Suggested change
| Expr.app (prepOp.app a) (sumList prepOp true as) | |
| as.foldr (fun x y => Expr.app (prepOp.app x) y) a |
There was a problem hiding this comment.
I tried this, but I think that it does not work: the a should really be the last element of the list. At least, this is what my understanding of foldr does. So, there may be some more idiomatic way of doing this, but the following would be closer to what it should be:
| l@(a::as) =>
if left_assoc? then
(l.dropLast).foldr (fun x y => Expr.app (prepOp.app x) y) l.getLast!
|
Thanks, and sorry for the delay! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
In this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/move_oper.20.20HAnd.2EhAnd.3F/near/403820462) it was pointed out that `move_oper` always assumes right-associativity also for `And/Or`. This PR makes `move_oper` left-associative on `And/Or`. Affected files: ```bash Tactic/MoveAdd test/MoveAdd ```
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
In this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/move_oper.20.20HAnd.2EhAnd.3F/near/403820462) it was pointed out that `move_oper` always assumes right-associativity also for `And/Or`. This PR makes `move_oper` left-associative on `And/Or`. Affected files: ```bash Tactic/MoveAdd test/MoveAdd ```
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
And/Or left-associativeAnd/Or left-associative
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
In this [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/move_oper.20.20HAnd.2EhAnd.3F/near/403820462) it was pointed out that `move_oper` always assumes right-associativity also for `And/Or`. This PR makes `move_oper` left-associative on `And/Or`. Affected files: ```bash Tactic/MoveAdd test/MoveAdd ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Zulip discussion it was pointed out that
move_operalways assumes right-associativity also forAnd/Or.This PR makes
move_operleft-associative onAnd/Or.Affected files: