[Merged by Bors] - chore: reduce imports of Data.List.Defs #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
1 task
thorimur
reviewed
Nov 28, 2023
Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
* was inferring `Nat` as arguments for `R` * note that `[Monoid M]`/`[Monoid N]` are variables
|
Pushed a couple small fixes (test imports + type signature—a win for the unused variables linter!); if it builds, then LGTM :) |
thorimur
approved these changes
Dec 1, 2023
sgouezel
reviewed
Dec 2, 2023
|
|
||
| -/ | ||
|
|
||
| set_option autoImplicit true |
There was a problem hiding this comment.
Could you just remove this line and add the missing type declaration for alpha below?
There was a problem hiding this comment.
Sure. It still makes me sad. :-)
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2023
Currently `Data.List.Defs` depends on `Algebra.Group.Defs`, rather unnecessarily. (This then prevents importing `Data.List.Defs` into `Tactic.Common`, without breaking various `assert_not_exists` statements.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Currently `Data.List.Defs` depends on `Algebra.Group.Defs`, rather unnecessarily. (This then prevents importing `Data.List.Defs` into `Tactic.Common`, without breaking various `assert_not_exists` statements.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Data.List.Defsdepends onAlgebra.Group.Defs, rather unnecessarily.(This then prevents importing
Data.List.DefsintoTactic.Common, without breaking variousassert_not_existsstatements.)